rose-pine / hyper

Soho vibes for Hyper
https://www.npmjs.com/package/hyper-rose-pine
31 stars 3 forks source link

Doesn't play well with other plugins that add/edit CSS. #11

Closed lmunozdiaz closed 10 months ago

lmunozdiaz commented 10 months ago
 return Object.assign({}, config, {
    padding: config.padding || "12px 30px 30px 30px",
    backgroundColor: palette.base,
    foregroundColor: palette.text,
    cursorColor: palette.highlightHigh,
    cursorAccentColor: palette.text,
    selectionColor: palette.highlightMed,
    borderColor: "#0000",
    css: `
        .tab_text { color: ${palette.subtle} }
        .tab_textActive { color: ${palette.text} }
    `,
    colors,
  });

The above code is missing

${config.css || ''}

before

.tab_text { }

so, any CSS from other plugins isn't merging with those from this one.

Solution:

css: `
    ${config.css || ''}
    .tab_text { color: ${palette.subtle} }
    .tab_textActive { color: ${palette.text} }
`