search

rose-pine / neovim

Soho vibes for Neovim
MIT License
2.3k stars 147 forks source link

dim inactive sign column #123

Closed sho-87 closed 1 year ago

sho-87 commented 1 year ago

Neovim version (nvim -v)

0.8.3

Terminal

Windows Terminal

Describe the bug

When using dim_nc_background = true, the sign column in inactive windows does not dim correctly, and still uses the active window bg colour:

image

Would it also make more sense to invert the bg colours? I would expect that when something is dimmed, it would get darker and not lighter

Steps To Reproduce

  1. Turn on sign column to the left of line numbers
  2. turn on dim_nc_background

Expected Behavior

  1. Sign bg colour to be dimmed like the rest of the inactive window

Repro

No response

mvllow commented 1 year ago

Thanks for pointing this bug out. I don't usually use this option and it definitely needed some love. #114 should greatly improve the experience when using dim_nc_background.

Inactive backgrounds are now actually dimmed instead of brightened and telescope.nvim should have a more consistent appearance.

Feel free to try it in the canary branch or wait for that to be merged into main soon :)

Edit: Also the "dim" colours are not part of our official palette so I'm happy to adjust per variant if needed for usability.

sho-87 commented 1 year ago

thank you!