rose-pine / neovim

Soho vibes for Neovim
MIT License
2.25k stars 144 forks source link

feat: add `WinBar` highlight group #177

Closed nabn closed 1 year ago

nabn commented 1 year ago

Add WinBar highlight group

mvllow commented 1 year ago

Apologies for the late review. I'm not 100% sure if this should be in the base theme—if WinBar is being used to show breadcrumbs for example, matching the base editor seems more ideal. Happy to revisit this but feel free to add this to your personal config:

highlight_groups = {
  WinBar = { bg = "surface" }
}
nabn commented 1 year ago

Thanks @mvllow!

I've tried overriding in the config, but I believe it didn't work because it wasn't defined in the base theme.

is there a more sensible value we could define for this highlight group in the base theme so it can be overridden?

mvllow commented 1 year ago

Hmm, you should be able to override WinBar without any additional changes. That being said, setting the background to surface may not be super noticeable so I would try love or another accent to test. Here's a complete example:

vim.opt.winbar = "%f"

require("rose-pine").setup({
    highlight_groups= {
        WinBar = { fg = "base", bg = "love" },
    },
})

vim.cmd.colorscheme("rose-pine")
nabn commented 1 year ago

Appreciate you looking into this.

this is what I've got in my (lazy.nvim) setup:

{
        "rose-pine/neovim",
        name = "rose-pine",
        opts = {
            higlight_groups = {
                WinBar = {fg = "base", bg = "love", underline = true},
                StatusLine = {fg = "love", bg = "love", blend = 80},
                StatusLineNC = {fg = "subtle", bg = "surface"}
            },
            dark_variant = "moon",
            disable_italics = true,
            bold_vert_split = true
        }
    }

and I'm setting the colorsheme like you've suggested. I uninstalled/re-installed just to rule out any local changes I might have made, however I'm still not seeing the override take effect.

Output of verbose hi WinBar once everything has loaded is WinBar xxx cterm=bold gui=bold last set from Lua. I commented out other colorschemes in my plugin config just to rule them out.

With nvim -u NORC, verbose hi WinBar says WinBar xxx cterm=bold gui=bold too.

If you think this should work out of the box, then there's potentially some other part of my setup messing up with it. I'm happy to try and figure it out myself.

mvllow commented 1 year ago

Not sure if you copied/pasted that snippet but you have a typo:

- higlight_groups = {
+ highlight_groups = {

Happy to help debug further if that wasn't the issue. Curious if your StatusLine overrides are working.

nabn commented 1 year ago

yeah I really am stupid 😅. thanks so much!