search

rose-pine / neovim

Soho vibes for Neovim
MIT License
2.25k stars 144 forks source link

chore: update highlights for which-key.nvim #287

Closed sjclayton closed 2 months ago

sjclayton commented 2 months ago

Updates highlight groups that have changed / been added for which-key.nvim, which has just had a new major version release (v3).

Fixes #285

sjclayton commented 2 months ago

This is ready for review as-is...

I will submit another PR addressing the improving the display of the icon highlight groups, the way in which they are handled in which-key is kind of a bit odd.

sjclayton commented 2 months ago

I just noticed I was on nightly when I was working on this, and when I switched back to nvim v0.10.0 the fixes don't work... So will have to put this on hold for now.

sjclayton commented 2 months ago

After some investigation I have determined that there is a bug in which-key that will be fixed by folke/which-key.nvim/pull/684 which is causing the fix not to take affect on the stable version of Neovim.

So as far as things being correct here, it would appear that everything is good now for this to be merged as-is. 😀

mvllow commented 2 months ago

Thank you for the thorough PR, much appreciated :)