search

rose-pine / neovim

Soho vibes for Neovim
MIT License
2.25k stars 144 forks source link

chore: update mini-icons highlights to use appropriate colors #295

Closed sjclayton closed 2 months ago

sjclayton commented 2 months ago

Brings things more in line with the current available palette. I left MiniIconsAzure as foam because mini-icons uses these colors for things like filetype icons as well and unlike how which-key uses it's colors there are a lot more file types.

mvllow commented 2 months ago

I'm fine with this for now but after seeing "text" used previously, perhaps we could replace one of the duplicate "pine" entries with "text" to not have any repeated colours (for both which-key and mini-icons)?

sjclayton commented 2 months ago

@mvllow

Mini-icons has only foam duplicated and which-key has only pine duplicated (under normal use) with the way things are now, and I think as far as icons go with this theme... using text which is basically white, tends to look really bad.

There was more duplication before my changes as in regards to mini-icons two hl groups were set to pine and two to foam. I left two set to foam in this change because two hl groups either had to stay as pine or foam.

So with mini-icons having more icons in the blue range that could end up the same if I set both MiniIconsAzure and MiniIconsBlue to pine... I left one as foam, and set MiniIconsCyan to foam, because it is the closest match to cyan in the palette.

Also, text was used previously for MiniIconsGrey and so I substituted in subtle in it's place, because it is actually grey. 😝

Hopefully this makes some kind of sense.