rose-pine / neovim

Soho vibes for Neovim
MIT License
2.3k stars 147 forks source link

Weird display when installing with vim-plug #85

Closed Jerome1337 closed 1 year ago

Jerome1337 commented 2 years ago

I'm using vim-plug to install every nvim plugins.

I installed the color scheme like this inside my .vimrc

call plug#begin(stdpath('data') . '/plugged')
    ...
    Plug 'rose-pine/neovim', {'as': 'rose-pine', 'tag': 'v1.*'}
call plug#end()

colorscheme rose-pine

Rose-pine is correctly installed but there is a weird black background and not the correct colors displayed.

Screenshot 2022-07-10 at 4 17 01 PM

Did I miss something ?

mvllow commented 2 years ago

If you're using neovim, which version? For regular vim it may not be working due to many parts being in lua / possibly neovim specific. If that's the case, I'd love to improve the experience on regular vim.

Otherwise, termguicolors may not be set correctly.

Happy to give more detailed steps if needed for anything 😌

Jerome1337 commented 2 years ago

@mvllow Im using neovim 0.7.2

~ ❯ nvim --version
NVIM v0.7.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by brew@HMBRW-A-001-M1-004.local

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.7.2/share/nvim"

Run :checkhealth for more info

My vim.init contains set termguicolors and my terminal emulator (Alacritty) has xterm-256color enabled

mvllow commented 2 years ago

Hmm can't seem to reproduce with a fresh install of neovim and only the following in init.vim:

call plug#begin('~/.vim/plugged')
    Plug 'rose-pine/neovim'
call plug#end()

colorscheme rose-pine

With alacritty (zero config) terminal:

Screenshot 2022-07-10 at 14 11 32

With kitty terminal:

Screenshot 2022-07-10 at 14 14 32
Jerome1337 commented 2 years ago

Yes, this is a bit weird, I configured my Alacritty with rose-pine theme and this seems to break the nvim colorscheme. I need to disable background inside nvim rose-pine config to make it work correctly.

Without disabled background:

Screenshot 2022-07-11 at 10 22 37 AM

With disabled background:

Screenshot 2022-07-11 at 10 22 56 AM
mvllow commented 2 years ago

I'm curious if everything looks fine if using kitty + rosé pine if you're able/willing to try that. The colors in your screenshots look slightly off as well as some elements like the statusline not being themed at all. If that does work we can narrow it down to an issue with alacritty or our theme for alacritty.

Jerome1337 commented 2 years ago

I did the test with Kitty, the colors a the same as Alacritty (with the disabled background). NeoVim config are the same on both terminal emulator.

Alacritty:

Screenshot 2022-07-25 at 10 49 59 AM

Kitty:

Screenshot 2022-07-25 at 10 49 54 AM

I don't know if there is a problem but the theme on Alacritty -> NeoVim with the disabled background seems fine

mvllow commented 1 year ago

Closing as I am unable to reproduce. Happy to revisit if the problem persists and can be reproduced.

mvllow commented 1 year ago

Ah! I wasn't too familiar with tmux at the time of this issue being created and after this issue arose again in our Discord, I realised tmux was being used here. I was able to reproduce and fix via the following:

# ~/.config/tmux/tmux.conf
set-option -g default-terminal        'screen-256color'
set-option -g terminal-overrides      ',xterm-256color:RGB'
# Start tmux with explicit TERM
TERM=xterm-256color tmux

Please note, I am not 100% sure which parts are doing what but this specific combination solved the problem for me. Would love if someone knows how to simplify what I'm trying to accomplish here :)

Quite the delay, but hope this helps someone!