search

rose-pine / rose-pine-site

The Rosé Pine garden
https://rosepinetheme.com
85 stars 29 forks source link

Unclear guides for contributor #119

Closed ghost closed 4 months ago

ghost commented 1 year ago
  1. Is it the Add a translation page on "Translate documentation" section are the correct path (src/content/{locale}/)? Since I saw now the directory is src/content/guides/{locale}/, so I would make some diff:
-1. Create a new page inside of src/content/{locale}/
-2. Reference the English equivalent page, or another locale you are comfortable with, e.g. src/content/en/create-a-theme.md
+1. Create a new page inside of src/content/guides/{locale}/
+2. Reference the English equivalent page, or another locale you are comfortable with, e.g. src/content/guides/en/create-a-theme.md
  1. Is it the Create a theme page on square bracket of number 3, the "Official repositories" section are forgot to add link with round bracket such as this diff:
-[creating an issue]
+[creating an issue](https://github.com/rose-pine/rose-pine-site/issues)
  1. Since I'm a new translation contributor, I did not know that I need to copy the pages manually on src/pages/{locale}/ so I can view the locale pages with pnpm dev. I need to mention that in contributing.md, there's also need to run pnpm build, but I got an errors. But the changes after I run pnpm build is, the pages are automatically generated on src/pages/{locale}/ (well that case I don't need to copied manually on that pages), but also make the src/data/org-members.json and src/data/org-repos.json an empty file because of that build errors and run pnpm dev, I also got Failed to parse JSON file. error. And fortunately, I just need to restore using git restore src/data/org-*, then run pnpm dev, and it's working normal.