search

rose-pine / rose-pine-site

The Rosé Pine garden
https://rosepinetheme.com
85 stars 29 forks source link

Weird looking language selection icon #129

Closed yheuhtozr closed 8 months ago

yheuhtozr commented 8 months ago

I guess the language selection icon on the top right side is hand-crafted, imitating the common one symbolizing 文 and A. However, the (alleged) Chinese character on the icon instead looks exactly like 丈 (which means: "fathom (a unit of average human height)", "size", "measurement") that makes the meaning of the icon confusing to whoever reads the character. Based on the overall style, I recommend that it should be changed somewhat like below.

current suggested
Screen Shot 2023-12-29 at 01 39 28 suggested_icon
fvrests commented 8 months ago

Thanks for catching that. Looks like the icon set used in the site has an outstanding issue to fix the icon: tabler/tabler-icons #416. I tweaked the icon to hopefully look more like the correct character in the style of the icon set. Please feel free to let us know if it's still not quite right or there are any other issues. :)

yheuhtozr commented 8 months ago

Thank you, I didn't know that the icon is taken from an existing set. Now it looks great to me.