rose-pine / rose-pine-site

The Rosé Pine garden
https://rosepinetheme.com
89 stars 29 forks source link

Add Turkish Translation #147

Closed slideglide closed 4 months ago

slideglide commented 4 months ago

Hello! this pull request adds Turkish translation to Rosé Pine's website and guides.

Some concerns I have:

netlify[bot] commented 4 months ago

Deploy Preview for rose-pine ready!

Name Link
Latest commit 8d2fe72a654c02e1af0124d52dbdf20aa00993eb
Latest deploy log https://app.netlify.com/sites/rose-pine/deploys/66892adee9af8b0008fc888e
Deploy Preview https://deploy-preview-147--rose-pine.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100
Accessibility: 97
Best Practices: 100
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

slideglide commented 4 months ago

oh this bot is awesome, the translation works!

also another concern i forgot to mention is that wrote "swafts" in sentence case as well

mvllow commented 4 months ago

Thank you for taking the time to add a translation! Everything looks great 💜

slideglide commented 4 months ago

@mvllow Thank you for merging my pull request! Is it okay for the Sentence case translations? Since I couldn't figure out if I should have used Title Case or Sentence case.

mvllow commented 4 months ago

I don't think we use title case anywhere, I prefer sentence case for most things :)