search

rose-pine / rose-pine-theme

All natural pine, faux fur and a bit of soho vibes for the classy minimalist
https://rosepinetheme.com
MIT License
1.19k stars 19 forks source link

RFC: Increase palette contrast #110

Open ThatOneCalculator opened 1 year ago

ThatOneCalculator commented 1 year ago

I've seen a lot of complaints about contrast/visual accessibility with Rose Pine Dawn, and I agree. I think the purple-on-cream doesn't provide enough contrast to those with limited color vision, and I think changing #575279 to something more like #3D3A55 or even #464261 would be good.

mvllow commented 1 year ago

I am happy to discuss here or in our Discord on ways to make both Dawn and Moon more accessible—with all colours, not just the text colour. These variants were made with WCAG AA compliance in mind but I would have to confirm with each colour if this is accurate or not. The Dawn text colour is AA on base and AAA on surface (at "normal" text size, according to https://color.a11y.com/ContrastPair/?bgcolor=faf4ed&fgcolor=575279).

Feedback from anyone affected, including yourself, would be much appreciated on if WCAG AAA (7:1 contrast ratio) is a good metric to judge the accessibility or not. If so, I will change any value necessary to meet that criteria :)

Of course, a WCAG rating doesn't have to be the final factor—if something has a passing 7:1 contrast ratio but is still inaccessible I would consider higher contrast for most palette options.

Thank you for bringing this up. This is an important topic that we've seen brought up about other variants and colours as well.

Edit: Added a discussion on Discord https://discord.com/channels/1090681740865052722/1107674766577516686/1107674766577516686

mvllow commented 1 year ago

I've been using #464261 for some time now in my Neovim/Kitty and quite enjoy the increased contrast.

I'm wondering if we should try to address the main variant's pine as well—using pine from moon looks good but would make the only difference between main/moon accents rose, which feels odd.

DannyJJK commented 3 months ago

The main color I struggle with is the gold text in Rose Pine Dawn. It seems to blend into the Dawn background a lot more than the other colours on my MacBook Pro 2019 monitor