rose-pine / tmux

Soho vibes for tmux
MIT License
135 stars 48 forks source link

Add disabled bg color option #19

Closed lluchkaa closed 11 months ago

lluchkaa commented 12 months ago

Add config option to allow users to set the color of disabled background.

On my machine when you set bg="0" it wasn't working. But if I use default, then it worked.

I'm using iTerm 3.4.20, MacOS Ventura 13.5.2, Apple M1.

mrs4ndman commented 12 months ago

I really think that this is a great addition. Was trying to figure it out on my own, but didn't know that it could break other people's environments. Have tested it locally on my machine and it works as intended. May I suggest something?

lluchkaa commented 12 months ago

I really think that this is a great addition. Was trying to figure it out on my own, but didn't know that it could break other people's environments. Have tested it locally on my machine and it works as intended. May I suggest something?

  • Add instructions for the set -g @rose_pine_bar_bg_transparent_option 'x', as it changes not based on a HEX color (what I first thought), but as the 1 - 8 (I believe). It will make for a great addition. Thanks!! 😃

@mrs4ndman do you mean you want to rename @rose_pine_bar_bg_disabled_color_option to @rose_pine_bar_bg_transparent_option only? Or do you want to add some extra text to README.md?

mrs4ndman commented 12 months ago

I want you to keep your option implementqtion + mine, and just add to the Readme a clear way to use it. My bad for the confusion

lluchkaa commented 11 months ago

I want you to keep your option implementqtion + mine, and just add to the Readme a clear way to use it. My bad for the confusion

@mrs4ndman actually, it looks like tmux allows to use these options for colors:

I used this article as reference.

Thank you for clarification, I'll add more details to README.md.

mrs4ndman commented 11 months ago

Great! Just add them as a commit to this PR and I will merge and close it :ok_hand: