search

rose-pine / tmux

Soho vibes for tmux
MIT License
135 stars 48 forks source link

Fix set -g and spacing on window names #6

Closed mrs4ndman closed 1 year ago

mrs4ndman commented 1 year ago

Reverts rose-pine/tmux#5

For some reason, this "bug" on @gkanwar 's setup breaks the window name updating. But this is the result on my setup: image It somehow breaks the window name in another way, and instead of the application that is running, it shows the current working directory for that window.

I need to look into this more in-depth. For now it gets a rollback. Sorry for the troubles

mrs4ndman commented 1 year ago

@gkanwar If you could provide me with your .tmux.conf for testing it would be nice. Either way I will be doing some testing of my own to figure this out. Thanks for pointing out the issue with your setup

Either way, the extraneous -g is required for the program, because, without it, it bugs out and does not work as intended. It looks like in the first screenshot, when it should look like this: image

gkanwar commented 1 year ago

If you could provide me with your .tmux.conf for testing it would be nice.

Sure, you can find it here: https://github.com/gkanwar/.dotfiles/blob/main/.config/tmux/tmux.conf

Either way, the extraneous -g is required for the program, because, without it, it bugs out and does not work as intended. It looks like in the first screenshot, when it should look like this

Very strange. I have exactly the opposite behavior.

I tested it out by running rose-pine.tmux directly in bash to find this error. I don't see why you should need -g, since this would be accepted as $1 in the definition of set here: https://github.com/rose-pine/tmux/blob/main/rose-pine.tmux#L25C1-L29C2

mrs4ndman commented 1 year ago

There is some really weird behavior that I didn't discover when I first wrote the plugin. I saw you were using a fork, but the changes shouldn't cause any malfunction.

Very strange. I have exactly the opposite behavior. I tested it out by running rose-pine.tmux directly in bash to find this error. I don't see why you should need -g, since this would be accepted as $1 in the definition of set here Just went and swapped configs and it works like you said, so it isn't a machine problem. And I did try deleting the -g on the local plugin file, and it leaves some whitespace around the window names (which I believe isn't intentional).

I am currently looking into it, but it seems like the options did collide with eachother (the -gq and -g, as you said). This is the result after the code changes that I show on the next photo: image image I will commit them, and I believe this fixes what you were mentioning. The features I tweaked (shown in the diff) somehow didn't get activated, so I didn't notice them.

Overall, thanks for making me notice these mistakes. Will mention this ;)

gkanwar commented 1 year ago

Glad it's sorted out :)