rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
495 stars 18 forks source link

No italic version ? #32

Closed tri-nga closed 3 years ago

tri-nga commented 3 years ago

First: Hello, this theme and the whole Rose-Pine palette are AWESOME! I need a little bit of time to get "used" to it but now I'm trying to use it (palette) everywhere I can.

I have tried to remove italics, I stole this settings from the Tokyo theme

"[Rosé Pine]": {
            "textMateRules": [
                {
                    "scope": [
                        "comment",
                        "meta.var.expr storage.type",
                        "keyword.control.flow",
                        "meta.directive.vue punctuation.separator.key-value.html",
                        "meta.directive.vue entity.other.attribute-name.html",
                        "tag.decorator.js entity.name.tag.js",
                        "tag.decorator.js punctuation.definition.tag.js",
                        "storage.modifier"
                    ],
                    "settings": {
                        "fontStyle": ""
                    }
                }
            ]
        }

but there is something italic here and there.

Could you provide a No Italics version too ?

mvllow commented 3 years ago

Appreciate the kind words 😌

Try these scopes instead:

"[Rosé Pine]": {
    "textMateRules": [
        {
            "scope": [
                "comment",
                "entity.other.attribute-name",
                "entity.other.inherited-class",
                "support.function",
                "variable",
                "meta.directive.vue"
            ],
            "settings": {
                "fontStyle": ""
            }
        }
    ]
}

I don't think we'll include non-italic variants on the marketplace but will look into adding the textMateRules to the readme in case they're ever updated :)