rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
451 stars 15 forks source link

Diff color setting missing (magit) #52

Closed christofferbergj closed 2 years ago

christofferbergj commented 2 years ago

Hi,

Great theme. Been using it for a while now!

I've found that when I use the extension Magit - https://github.com/kahole/edamagit, the diff view has no colors. I have searched for a very long time trying to figure out exactly what setting Magit uses to color the diff views, but with no luck (no experience with creating themes).

Magit has colors in many other themes, e.g. "Field Lights", "Gruvbox" and the default theme of VSCode. Palenight is also missing colors for the Magit view.

Hope someone can help or point me in a settings direction, so I can create the PR.


Rosé Pine Moon:

CleanShot 2022-02-10 at 14 33 03

Field Lights:

CleanShot 2022-02-10 at 14 32 56

mvllow commented 2 years ago

Thank you for the kind words 😌 We'll have a look and see how that extension is getting its colours. Off the top of my head – it may have to do with our diff colours being borders only instead of coloured text