rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
477 stars 17 forks source link

Minimized CSS highlight very similar to search result highlight #60

Closed WebShapedBiz closed 2 years ago

WebShapedBiz commented 2 years ago

Hi.

VSCode, when editing minimized CSS that has an error, highlights all the content. This error highlight color is very similar to the search result highlight color so I always have to switch to another theme when doing a search.

Here is the screenshot: Slika zaslona s 2022-05-10 10-34-49

It's very difficult to spot a result, especially on full screen and with short search keywords, like two or three characters, which are not repeating on the same viewport.

Thank you for this beautiful theme.

Cheers.

mvllow commented 2 years ago

Hmm, can't seem to reproduce the gold-ish selection. Are you able to provide a list of your installed extensions?

code --list-extensions

As far as the hard to read search match, see #58 😌 Hopefully VSCode allows editing the foreground soon

WebShapedBiz commented 2 years ago

Thank you @mvllow for your quick reply. Here is the list of my extensions:

abusaidm.html-snippets
ban.spellright
bungcip.better-toml
dbaeumer.vscode-eslint
ginfuru.better-nunjucks
HookyQR.beautify
jripouteau.adonis-vscode-extension
kumar-harsh.graphql-for-vscode
mvllow.rose-pine
Nixon.env-cmd-file-syntax
PKief.material-icon-theme
rubjo.ultimate-dark-neo
Shan.code-settings-sync
vincaslt.highlight-matching-tag
wayou.vscode-todo-highlight
xabikos.JavaScriptSnippets

Cheers.

mvllow commented 2 years ago

Unfortunately I am still unable to reproduce the gold highlighting 😔 Are you overriding Rosé Pine colours at all? Your screenshot shows some blue underlines in the UI and I'm wondering if maybe something in your settings.json is causing problems.

WebShapedBiz commented 2 years ago

Thank you for your time and effort @mvllow, but I have to disappoint you. I've never touched any color settings in my settings.json.

mvllow commented 2 years ago

One more idea if you don't mind: try disabling all extensions (possible via the UI, https://github.com/microsoft/vscode/issues/81950#issuecomment-554936557) and only enable Rosé Pine. You will need to reload the window and make sure Rosé Pine is applied. Ideally that would remove the gold highlight colour.

Appreciate your help trying to debug this 😌

WebShapedBiz commented 2 years ago

Gladly but in the meantime, I've changed and processed my SCSS several times and now I don't have that highlight at all, and if I make some manual errors, VSCode underlines only those characters, not using highlight at all.

Sorry, I'll try to reproduce it somehow and then disable all plugins but Rosé Pine.

Thank you for your time and effort.

WebShapedBiz commented 2 years ago

OK, I've managed to get my hands on the original file that I used to take a screenshot. I've disabled all my extensions except the Rosé Pine theme and everything is exactly like on the screenshot I've sent you. The search highlight is barely visible.

Sorry.

mvllow commented 2 years ago

Ah well I'm glad it doesn't happen with every file. Thanks for all the testing! Going to close this in favour of #58 since that has to do with the actual highlight of the result 😌