rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
451 stars 15 forks source link

Jupyter notebook cells are verrrrrry faint #72

Closed gwenwindflower closed 1 year ago

gwenwindflower commented 1 year ago

I recently started using VSCode for Jupyter notebooks and realized that at present Rosé Pine's colors for cells and cell highlighting are barely legible. This is in both dark and light versions.

I've included screenshots of both, along with a screenshot of the Github Light theme for contrast of how legible and accessible the expectation would normally be.

I'm happy to toy with this if pointed in the right direction and submit a PR ☺️, not a huge deal to switch themes while working in Jupyter for the time being, but I of course think Rosé Pine is the greatest theme of all time and would love to help make it work for this use case.

Screen Shot 2022-11-17 at 11 02 59 Screen Shot 2022-11-17 at 11 03 11 Screen Shot 2022-11-17 at 11 03 28
mvllow commented 1 year ago

Thanks for the report! Happy to guide you through creating a PR:

  1. Clone your forked copy of the repo, e.g. git clone git@github.com/gwenwindflower/vscode rose-pine-vscode
  2. Install dependencies via npm install or similar
  3. Navigate to the notebook highlights in within _pinecone-color-theme.json
  4. Changing this file effects all three variants. Build these variants via npm run build. Alternatively, you may npm run watch to automatically build on save.

Within _pinecone-color-theme.json you have access to our palette as variables prefixed with "$", e.g. $rose or $surface.

Ask away with any questions, this is motivation for me to put together a simpler contributing guide soon :)

gwenwindflower commented 1 year ago

awesome, makes sense, i'm on it! 🙏🏻

gwenwindflower commented 1 year ago

here's where i landed https://www.loom.com/share/4697650610dd40b591de18ce56746c79

i'm going to reimplement these changes quickly on a fresh branch because i just noticed: a) you prefer all lowercase commit messages b) vscode autoformatted a ton of bracket spacing that i'm sure you don't want changed