rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
495 stars 18 forks source link

No italic #75

Closed babakfp closed 1 year ago

babakfp commented 1 year ago

Hi

Rose Pine theme:

Screenshot 2022-12-04 120257

Another theme:

Screenshot 2022-12-04 120236

I don't like italic text because it's hard for me to read it. It will be awesome to be able to change it like this:

Screenshot 2022-12-04 120935

Thanks

mvllow commented 1 year ago

We do have a section in the readme for disabling italics, although not the cleanest solution. Happy to accept a PR that adds non-italic variants. Our build tool, pinecone, actually makes this pretty simple. Otherwise I can probably get to it in the next few days :)

babakfp commented 1 year ago

Update: I didn't submit a PR because I realized I don't know anything about writing a vscode extension.

mvllow commented 1 year ago

No worries, maybe @fvrests can generate non italic variants if they have time/agree with adding these :)