rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
451 stars 15 forks source link

Support to change Astro file icon #88

Closed ng-hai closed 1 year ago

ng-hai commented 1 year ago

I'm new to Astro, and they recommend installing their extension to support .astro file. It also results in unsupported file icon in Rosé Pine theme.

image

I have also searched in their repo but don't know how VS Code extension work to change my preference, could we do it from our side?

https://github.com/withastro/language-tools/blob/main/packages/vscode/syntaxes/astro.tmLanguage.json

I guess we could include another file type (which is astro) to our specs https://github.com/rose-pine/vscode/blob/main/icons/rose-pine-icon-theme.json

Please guide me if I can help.

mvllow commented 1 year ago

I tried overwriting *.astro and **/*.astro in our "rose-pine-icon-theme.json" with no luck—the icon remained as the Astro icon. The Svelte extension doesn't seem to share this issue, and other file icon themes do not seem to successfully overwrite the Astro one. I could be missing something, though.

ng-hai commented 1 year ago

Thanks, I will raise an issue on Astro repo as well.

ng-hai commented 1 year ago

Seems like they can't solve this issue either

mvllow commented 1 year ago

Their reply in that issue helped, I should have looked harder! I have a fix ready, just need to push and publish :)

ng-hai commented 1 year ago

Awesome ❤️