search

rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
495 stars 18 forks source link

Remove unnecessary shadows #93

Closed amalchuk closed 9 months ago

amalchuk commented 9 months ago

These changes remove an unnecessary and almost invisible shadows. Be much more minimal 🙂

Before:

before_widget

After:

after_widget
amalchuk commented 9 months ago

@mvllow, @fvrests Hello there! 🐈 Please, review.

amalchuk commented 8 months ago

Closed without any comments by maintainers... Good job, @mvllow 👏🏻

mvllow commented 8 months ago

We spend a lot of our free time looking at issues. Pinging two members less than 24 hours after creating the PR requesting review was not necessary.

As far as removing shadows, I don't see any reason to remove them unless they look bad or are visually causing issues.

I would apologise for a possible misunderstanding but judging by your last comment I believe I interpreted your pings appropriately.