search

rosecat-dev / IndividualKeepInv

Server-side Fabric mod that makes keepInventory work on an individual basis.
MIT License
1 stars 3 forks source link

KeepInventory state is being reset upon server reboot. #3

Closed Neulooo closed 1 year ago

Neulooo commented 1 year ago

This issue is not impacting people that joined after the mod has been updated to 1.0.1 as heavily, as their keepInventory state is being reset to True (server's default), but for other people it's getting set to false, which has already heavily impacted some individuals on the server.

For context, it has been tested on both pre-1.0.1 player who had their keepInventory state set to True and after server restart it went back to False, and on a post-1.0.1 player who had their keepInventory state set to False, which after restart got set to True. I'm not actually sure if this update has affected this behaviour or if it could be noted even prior to that, but still.

rosecat-dev commented 1 year ago

Extremely sorry to hear that this has affected your players. Working on a fix now.

rosecat-dev commented 1 year ago

Think I've found the issue. The writeNbt method responsible for writing player states to disc when a server closes does not appear to be running after the first time the server closes.

rosecat-dev commented 1 year ago

individualkeepinv-1.0.3-TEST.zip

This should fix it. writeNbt runs every time a server closes now. Please tell me if so/if not!

Neulooo commented 1 year ago

Over a day has went by and I have come back with results. Since to install the mod we've had to restart the server, thus resetting everyone's state, it was a bit bothersome having to notify everyone on login and in tab menu that they should change their keepInventory state, but outside of that we've had no reported issues regarding lost items or similar problems.

We do have now a contingency in form of a inventory backup mod, so future issues shouldn't be as impactful.

Also, not sure when this was implemented, but thanks for making the "getdefault" subcommand.