search

rosedblabs / rosedb

Lightweight, fast and reliable key/value storage engine based on Bitcask.
https://rosedblabs.github.io
Apache License 2.0
4.58k stars 632 forks source link

reduce excess code #231

Closed Jeremy-Run closed 1 year ago

Jeremy-Run commented 1 year ago

If a key exists in the Index of DB, then record.Type can't be LogRecordDeleted, otherwise I suggest deleting it from the index.

Jeremy-Run commented 1 year ago

@roseduan Do you think it's a good idea to just delete it from the index?

roseduan commented 1 year ago

@roseduan Do you think it's a good idea to just delete it from the index?

I guess no, because we assume it will never happen, so an assert seems reasonable.

Jeremy-Run commented 1 year ago

I accidentally closed this pr. 😂