search

rosedblabs / rosedb

Lightweight, fast and reliable key/value storage engine based on Bitcask.
https://rosedblabs.github.io
Apache License 2.0
4.48k stars 620 forks source link

[BUG] unknown field BlockCache in struct literal of type wal.Options #314

Closed bengarrett closed 3 weeks ago

bengarrett commented 4 weeks ago

Hi, the recent release of rosedblabs/wal v1.3.7 breaks the current main release of rosedb v2.3.6.

remove block cache(https://github.com/rosedblabs/wal/commit/e77db044463f4ba32455b7a0b42db3161248b5a4)

It causes the compile errors when when using rosedb in an app after running go get -u.

// go.mod
require (
    github.com/rosedblabs/rosedb/v2 v2.3.6
)

require (
    github.com/rosedblabs/wal v1.3.7 // indirect
)
$ go run .

../../go/pkg/mod/github.com/rosedblabs/rosedb/v2@v2.3.6/db.go:160:3: unknown field BlockCache in struct literal of type wal.Options
../../go/pkg/mod/github.com/rosedblabs/rosedb/v2@v2.3.6/merge.go:199:3: unknown field BlockCache in struct literal of type wal.Options
../../go/pkg/mod/github.com/rosedblabs/rosedb/v2@v2.3.6/merge.go:221:3: unknown field BlockCache in struct literal of type wal.Options
../../go/pkg/mod/github.com/rosedblabs/rosedb/v2@v2.3.6/merge.go:384:3: unknown field BlockCache in struct literal of type wal.Options
roseduan commented 3 weeks ago

Thanks.

I will release a new version to fix it.

roseduan commented 3 weeks ago

v2.3.7 is released, please use the latest version to fix this issue.