search

rosekamallove / youtemy

A great way to learn from YouTube courses without any distractions and the ability to enroll in courses and track them with a daily streak to become more consistent.
https://youtemy-bc22a.firebaseapp.com/
MIT License
39 stars 12 forks source link

Add thumbnail links to Courses Page #62

Closed rosekamallove closed 2 years ago

rosekamallove commented 3 years ago

Currently, the course page uses downloaded images, it would be better to use a URL of the thumbnail image and pass it to the addBookmarks() function

handleAddToBookamrk(
    "PLWKjhJtqVAbnSe1qUNMG7AbPmjIG54u88",
    uid,
    "HTML, CSS - FreeCodeCamp"
    "THUMBNAIL_URL"  //currently this doesn't exist
);
tuanthanh2067 commented 2 years ago

Hello is it still a problem as I don't know how to reproduce

const handleAddToBookamrk = async (
  playlistID,
  uid,
  title = "Untitled",
  thumbnail = "https://i.stack.imgur.com/y9DpT.jpg"
) => {
rosekamallove commented 2 years ago 
const handleAddToBookamrk = async (
  playlistID,
  uid,
  title = "Untitled",
  thumbnail = "https://i.stack.imgur.com/y9DpT.jpg" // This is a placeholder image, if the function call doesn't povide the image and title.
) => {

So if you bookmark a course from the Courses page it adds these placeholders, so it would be nice to add thumbnails.

rosekamallove commented 2 years ago

But I don't think you should contribute now, I am thinking of a re-write in Next.js and writing my own backend in Deno and MongoDB