Not works in php8 - Githubissues

rosell-dk / webp-convert

Convert jpeg/png to webp with PHP (if at all possible)

MIT License

578 stars 102 forks source link

Not works in php8 #265

Closed rickfleen closed 3 years ago

rickfleen commented 3 years ago

When I run composer update:

Problem 1

Root composer.json requires rosell-dk/webp-convert ^2.4 -> satisfiable by rosell-dk/webp-convert[2.4.0].
rosell-dk/webp-convert 2.4.0 requires php ^5.6 | ^7.0 -> your php version (8.0.2) does not satisfy that requirement.

ceesvanegmond commented 3 years ago

Having the same issue. Would love to see this fixed ❤️

lobodol commented 3 years ago

Hi there,

Do you plan to make this library php8-ready soon?

Regards,

nlxdodge commented 3 years ago

Please us the 👍 on the first comment to show interests in this feature. I myself made an automatic webp converter for all assets in my portfolio, but I switched to PHP 8.0+ and the images didn't work anymore. This is also the issue I am experiencing.

rosell-dk commented 3 years ago

I think its php8-ready now. I at least fixed issues found in test cases and phpstan. I shall release soon.

rosell-dk commented 3 years ago

Btw: I updated to newer version of PHPUnit (9.3). But that requires PHP 7.3. So requirements for dev is now PHP 7.3. The library however still works in PHP 7.3, 7.2, 7.1, 7.0 and 5.6 - its just the dev requirements that has been pushed up.

rosell-dk commented 3 years ago

Fixed