The ngx-onboarding doesn't work properly in a popup window

rosen-group / ngx-onboarding

Onboarding module for Angular applications

Other

52 stars 13 forks source link

The ngx-onboarding doesn't work properly in a popup window #38

Closed afcaceres closed 5 years ago

afcaceres commented 5 years ago

The problem is that in the popup window the controls selected to be explained are shown dark and not light like in the rest of the window.

ngx-onboarding popup

SDohle commented 5 years ago

Hi,

I've just released version 1.2.2 which should fix the problem. Can you please test it @afcaceres
Thanks!

SDohle commented 5 years ago

@afcaceres Can you confirm the bug is fixed with version 1.2.2?

afcaceres commented 5 years ago

Hi,

I have been testing the new release, but it doesn't work completely good.

Now the pop-up window is displayed, but it doesn't indicate the control I want to explain. It is not possible to explain a control that is inside of the popup window

Thanks!

SDohle commented 5 years ago

Thanks for the Feedback, @afcaceres

@MichaelKirchner

MichaelKirchner commented 5 years ago

Hi @afcaceres , can you add a screenshot? Thanks!

afcaceres commented 5 years ago

Hi @MichaelKirchner

In this picture it should be remark the cancel button

Thanks

miller45 commented 5 years ago

@afcaceres can you add some details to the "popup" dialog? Can you provide and html snippet with the button? Is the popup maybe embedded in an iframe?

afcaceres commented 5 years ago

Hi @miller45

We use Devexpress controls for the popup and the button

snippet.txt

SDohle commented 5 years ago

@MichaelKirchner

miller45 commented 5 years ago

After installing devExtreme controls and your @afcaceres snippet in our demo app, I could reproduce the problem... The shadow of our onboarding was behind the shadow of the dxPopup. I think I have fix for the problem which works...#48 dxonboardingfix Lets wait what @MichaelKirchner has to say

SDohle commented 5 years ago

Hi @afcaceres, i've released version 1.2.4 with the bugfix just now. Can you test it please. Thanks!

Best regards Steffen

miller45 commented 5 years ago

@afcaceres Does it work now?

afcaceres commented 5 years ago

Hi @SDohle @miller45

It works perfect!

Thank you very much!

Angelica

SDohle commented 5 years ago

Hi Angelica, Thanks for testing & feedback! 👍