rosen-group / ngx-onboarding

Onboarding module for Angular applications
Other
52 stars 13 forks source link

Consider removing lodash-es usage #88

Closed solkaz closed 2 years ago

solkaz commented 3 years ago

I wanted to ask if there was a specific reason to use lodash-es in the project? It uses the following utilities (search result), which either have native equivalents, or easy replacements:

SDohle commented 3 years ago

Hi, we created this module to consume it in a project which is using lodash. There is no other technical reason. Feel free to provide a pull request because I'm not sure if some of our developers will find time for that refactoring.

miller45 commented 2 years ago

loadash-es supports tree-shaking without webpack 4. So the impact should be minimal because only the functions we use. The reason we using them is basically that at the time the code was initially written our typescript version did not support the ? operator, so back then it would be always if( value != null || value.length == 0) and today webstorm would mark that as code duplicate if we use that a lot...