rosepearson / GeoFabrics

A package for generating hydrologically conditioned DEMs and roughness maps from LiDAR and other infrastructure data. Check the wiki for install and usage instructions, and documentation at https://rosepearson.github.io/GeoFabrics/
GNU General Public License v3.0
25 stars 11 forks source link

Improve river estimation stage - address downriver wall artefacts #245

Open rosepearson opened 5 months ago

rosepearson commented 5 months ago

The river estimation approach appears to introduce an 'wall artefact' down river amplified from any high elevation values detected along the measured cross section data.

As an example:

"See below the strange artifact of a ridgeline in the river that seems like an exaggerated version of a small positive feature in the surveyed XS (0.5 m), increased to 3 m in the interpolated data and extending to the next XS upstream and downstream." image

Starting point: Could it be due to the taking the nearest point along the measured sections instead of interpolating the value nearest to the sample locations.. https://github.com/rosepearson/GeoFabrics/blob/main/src/geofabrics/bathymetry_estimation.py#L772

rosepearson commented 4 months ago

Also support providing just a thalweg and wetted area instead of river banks. If providing the wetter area the thalweg is not optional it is required.

rosepearson commented 4 months ago

Update documentation to make it clearer what formats are supported.