search

rosetta-rs / template-benchmarks-rs

Collected benchmarks for templating crates written in Rust
229 stars 29 forks source link

Add horrorshow bench #2

Closed lnicola closed 6 years ago

lnicola commented 6 years ago

Part of #1.

Comes with some bad news :smile:.

There is a slight difference in behaviour: horrorshow escapes everything by default. I let it escape the team name because that seems like the reasonable thing to do. I didn't escape the numbers, since I'm not sure what that does.

Maybe the other benches should be updated to behave the same way?

lnicola commented 6 years ago

Hey, this looks great! Will you submit a PR?

Sorry? :smile: This is a PR (although it might need to be rebased).

djc commented 6 years ago

Huh, I hadn't enabled watching yet on this repo, so had missed the PR!

Actually I think Tera and Askama also do escaping by default, not sure about the others. But this should be fine for now, let me see about rebasing this on top of my changes.

lnicola commented 6 years ago

Haha, no worries. I probably won't get to rebase this until next week, so if you want, you can update it for Criterion.

I also pinged you on Gitter about the Handlebars bench. EDIT: @djc

djc commented 6 years ago

I've rebased your patch as 8797f123a9e5fc89ac12cc8f6fca615c08f345f5. Thanks!

Uh, where on Gitter did you ping me? I didn't see anything.