rosettatype / eczar

Eczar: fonts for Devanagari and Latin
SIL Open Font License 1.1
61 stars 6 forks source link

Fix shaping for Safari #14

Closed davelab6 closed 8 years ago

davelab6 commented 9 years ago

When I use Safari Version 7.1.6 on Mac OS X 10.9 to review http://www.impallari.com/testing/index-devanagari.php#sample_one (you need to click the 'Sample 1' tab link near the top right) then the shaping isn't working

MrBrezina commented 9 years ago

Hm. I see this. Are we sure 10.9 supports dev2 OT layout?

screen shot 2015-06-17 at 20 53 40

davelab6 commented 9 years ago

Its a problem in a bunch of fonts - eg https://github.com/typeoff/martel_sans/issues/5#issuecomment-112940656 :)

MrBrezina commented 9 years ago

My first guess would be that deva is used in older Mac OS X systems instead of dev2.

davelab6 commented 9 years ago

First I made a copy of all the Devanagari fonts currently checked in to GF:

# in the gf collection
cd github.com/google/fonts/ofl;
# make a list of all directories with fonts supporting devanagari
grep devanagari */META* | cut -d\/ -f1 > deva 
# copy all those fonts into a directory
mkdir devaf; 
for i in `cat deva`; do echo $i; cp $i/*ttf devaf/; done;

Then I opened Safari and checked them all, and moved them into 2 new directories, working and not-working.

Then I split out all their gsub tables with ttx:

ttx -t GSUB */*ttf ;

then I searched for fonts with a deva table that work:

grep \"deva\" */*x | grep "works" | cut -d\/ -f2 | cut -d\- -f1 | sort | uniq | tee deva-works.txt ;
Arya
Bhavuka
Biryani
Dekko
Dinah
EkMukta
Glegoo
Halant
Hind
InknutAntiqua
Jaldi
Kalam
Karma
Khand
Kurale
Laila
Modak
Poppins
PragatiNarrow
Rajdhani
Ranga
RhodiumLibre
RozhaOne
Sarpanch
Sitara
Teko
Tillana
VesperLibre

and then for fonts with a deva table that do not work:

grep \"deva\" */*x | grep "not work" | cut -d\/ -f2 | cut -d\- -f1 | sort | uniq | tee deva-notwork.txt ;
Amita
Asar
Cambay
Khula
Martel
MartelSans
Palanquin
PalanquinDark
Sahitya
Yantramanav

And the same for dev2:

grep \"dev2\" */*x | grep "works" | cut -d\/ -f2 | cut -d\- -f1 | sort | uniq | tee dev2-works.txt ;
Arya
Bhavuka
Biryani
Dekko
Dinah
EkMukta
Glegoo
InknutAntiqua
Jaldi
Kurale
Modak
Poppins
PragatiNarrow
RhodiumLibre
Sitara
Tillana
VesperLibre

And not works:

grep \"dev2\" */*x | grep "not work" | cut -d\/ -f2 | cut -d\- -f1 | sort | uniq | tee dev2-notwork.txt ;
Amita
Asar
Cambay
Eczar
Kadwa
Khula
Martel
MartelSans
Palanquin
PalanquinDark
Sahitya
Sarala
Sumana
Sura
Yantramanav

Finally I compared these:

meld dev*-works* ;

screen shot 2015-06-17 at 8 32 05 pm

From this I conclude a dev2 table is not needed, since the families shown above in green lack a dev2 table, but work in Safari.

MrBrezina commented 9 years ago

In other words: you proved that properly coded deva is necessary for Mac OS X 10.7–10.9. dev2 is only supported from 10.10. dev2 is still needed a) in other applications, b) to get better shaping, esp. better control over interaction of conjuncts and matra i (ikar).

Just to be clear here. We operated with the brief that dev2 is not needed based on some examples provided by Google. And supporting the deva is little backwards. I will see this fixed soon-ish.

davelab6 commented 8 years ago

Any updates on this?

MrBrezina commented 8 years ago

I will get to it asap.

On 02 Oct 2015, at 19:11, Dave Crossland notifications@github.com wrote:

Any updates on this?

— Reply to this email directly or view it on GitHub.

MrBrezina commented 8 years ago

Sorry it took so long. Also, please do test it. I do not have old Mac OS X installed anywhere near.

On 2. 10. 2015, at 19:11, Dave Crossland notifications@github.com wrote:

Any updates on this?

— Reply to this email directly or view it on GitHub https://github.com/rosettatype/eczar/issues/14#issuecomment-145111595.