search

rosettatype / yrsa-rasa

Yrsa & Rasa: fonts for Latin and Gujarati
http://github.rosettatype.com/yrsa-rasa
SIL Open Font License 1.1
245 stars 18 forks source link

Copyright string must be ascii #1

Closed davelab6 closed 8 years ago

davelab6 commented 8 years ago

Your copyright strings are non-ascii, eg

    <string>Copyright © 2016 by Rosetta Type Foundry. All rights reserved.</string>

https://github.com/rosettatype/yrsa/blob/master/Production/UFOs/Rasa-Light.ufo/fontinfo.plist#L10

I suggest that, similar to 

Copyright (c) 2014, Vaibhav Singh (design) and Rosetta Type Foundry s.r.o. (post-production).

https://github.com/rosettatype/eczar/blob/master/Design/Eczar-Bold.glyphs#L37

We change it to

    <string>Copyright (c) 20XX Rosetta Type Foundry (info@rosettatype.com)</string>

where the year is the first year you started working on it.

MrBrezina commented 8 years ago

Ah. this gets changed in AFDKO anyway, but I will update it the way you like it.

On 6. 2. 2016, at 21:54, Dave Crossland notifications@github.com wrote:

Your copyright strings are non-ascii, eg

<string>Copyright © 2016 by Rosetta Type Foundry. All rights reserved.</string>

https://github.com/rosettatype/yrsa/blob/master/Production/UFOs/Rasa-Light.ufo/fontinfo.plist#L10 https://github.com/rosettatype/yrsa/blob/master/Production/UFOs/Rasa-Light.ufo/fontinfo.plist#L10 I suggest that, similar to

Copyright (c) 2014, Vaibhav Singh (design) and Rosetta Type Foundry s.r.o. (post-production). https://github.com/rosettatype/eczar/blob/master/Design/Eczar-Bold.glyphs#L37 https://github.com/rosettatype/eczar/blob/master/Design/Eczar-Bold.glyphs#L37 We change it to

<string>Copyright (c) 20XX Rosetta Type Foundry (info@rosettatype.com)</string>

where the year is the first year you started working on it.

— Reply to this email directly or view it on GitHub https://github.com/rosettatype/yrsa/issues/1.

davelab6 commented 8 years ago

You mean FDK will remove the nonascii char?

MrBrezina commented 8 years ago

I mean that there are name table overrides in the AFDKO feature files. I rewrite most of the font info there, this was just a leftover from Glüphs.