search

rosflight / rosflight_ros_pkgs

ROS packages for the ROSflight autopilot
http://rosflight.org/
BSD 3-Clause "New" or "Revised" License
86 stars 56 forks source link

Added GPS plugin in SITL from rosflight_plugins #110

Closed Georacer closed 4 years ago

Georacer commented 4 years ago

Simulation should now publish gnss and navsatfix topics properly

Also edited the parent_frame_id property of fixedwing model, to conform with multirotor

superjax commented 4 years ago

Thanks! I should have time to look at this this evening.

superjax commented 4 years ago

@dpkoch, would you like to weigh in on this? This adds a dependency on rosflight_plugins to roslfight_sim.

Georacer commented 4 years ago

On second thought, it might not be the best move to add the dependency (which I should also have added in the package.xml but didn't). I could withdraw this PR and replicate the plugin functionality within the rosflight simulator, but I thought since both rosflight and rosflight_plugins are from the same University, then all utility packages are fair game. Whatever you decide.

superjax commented 4 years ago

Yeah, I think that the latter makes sense. See discussion on #109. I think supersedes this PR