Missing frame_id for the published attitude/euler message

rosflight / rosflight_ros_pkgs

ROS packages for the ROSflight autopilot

http://rosflight.org/

BSD 3-Clause "New" or "Revised" License

86 stars 56 forks source link

Missing frame_id for the published attitude/euler message #142

Closed sayali-purdue closed 9 months ago

sayali-purdue commented 3 years ago

No frame_id field has been set for the euler_msg (of type geometry_msgs::Vector3Stamped) that is published at line 439 in rosflight_io.cpp. I believe that coordinate frame information of the published data would be useful to other users of the node, makes code more readable.

superjax commented 3 years ago

Could be! Feel free to submit a PR! :wink: