rosflight / rosflight_ros_pkgs

ROS packages for the ROSflight autopilot
http://rosflight.org/
BSD 3-Clause "New" or "Revised" License
86 stars 56 forks source link

Move udp_board and rosflight_firmware to sim package #149

Closed bsutherland333 closed 9 months ago

bsutherland333 commented 9 months ago

As part of pull request #408 from the firmware repo and pull request #148 from this repo, I am moving the firmware submodule and the udp_board class directly into the rosflight_sim package.

The motivation for this stems from the fact that both the firmware and the udp_board are only intended to be used for simulation purposes, and were originally separated only to avoid requiring gazebo dependencies if someone wanted to build off of udp_board. However, having both a ROS package named rosflight_firmware and a non-ROS repository named rosflight_firmware is a bit confusing, and we have plans to make the sim package more modular so it could be built without gazebo if so desired anyways.

Do to this, I put udp_board directly into the rosflight_sim package, with rosflight_firmware existing as a separate library within rosflight_sim. Currenlty the build files for the rosflight_firmware is found in the CMakeList.txt file for the rosflight_sim package, but this could be moved directly into the firmware repo if so desired. This would put ROS files in a non-ROS repo though.