rosflight / rosplane

Fixed-wing autopilot for ROSflight
BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

45 update rosplane messages for alternate flight modes #51

Closed bsutherland333 closed 3 weeks ago

bsutherland333 commented 3 weeks ago

In preparation for alternative flight modes, I reworked the tuning debug topics to utilize the existing controller command topic instead of a separate debug topic. I did this because if we want to accept roll and pitch commands as commands during actual use cases and not just debugging, then calling them debug doesn't make a lot of sense. Putting those commands next to the other commands makes more sense.

Since we still want to see what commands are being sent to the roll and pitch loops when those are not being commanded, I replaced the debug publishing with the same controller commands message. We could still keep a debug message type and topic, but since the controller commands message now has most of the information we need, I thought it was simpler to reuse and merge them.

What do you guys think, is reusing the same message a good idea or should we still keep the debug separate?

bsutherland333 commented 3 weeks ago

I also fixed incorrect terminology in signal generator

bsutherland333 commented 3 weeks ago

Actually after thinking about it more, using separate messages would probably be the best solution. Less empty data being published, and less confusion as to what topics contain the actual command to the autopilot. I'll make that change.