roshbaik2 / open-zwave

Automatically exported from code.google.com/p/open-zwave
0 stars 0 forks source link

COMMAND_CLASS_CENTRAL_SCENE #367

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use the BeNext Scene Controller 
(http://www.benext.eu/en/products/scene-controller/)

What is the expected output? What do you see instead?
Activate a scene when pushing a button

What version of the product are you using? On what operating system?
Rev 903 on linux

What branch of the code were you using? (if you just followed the
instructions on the source checkout page, then say trunk.. if you checked
out a branch, please let us know what branch it was)
Trunk

Please include the file OZW_Log.txt from your program. Make sure the file
zwcfg*.xml is NOT present.

Please provide any additional information below.

Hello,
It seems that the command class 0x5b is not supported.
Log message: ApplicationCommandHandler - Unhandled Command Class 0x5b

The node is Node018

Thanks you !

Original issue reported on code.google.com by tmartine...@gmail.com on 17 Sep 2014 at 12:30

Attachments:

GoogleCodeExporter commented 9 years ago
It's a new CC if never heard of. We would need to reverse engineer the 
protocol. I imagine it would be straight forward. Let me know if your willing 
to help out with that. 

Original comment by jus...@dynam.ac on 17 Sep 2014 at 7:04

GoogleCodeExporter commented 9 years ago
Thanks for your reply.
Tell me what i need to do for help ?

Original comment by tmartine...@gmail.com on 17 Sep 2014 at 7:08

GoogleCodeExporter commented 9 years ago
I need to create a skeleton class first. I'm a bit backed up in work at the 
moment, but I'll try to get to it next week. 

Original comment by jus...@dynam.ac on 20 Sep 2014 at 4:41

GoogleCodeExporter commented 9 years ago
Hello,
I've made the changes to integrate this Command Class.
Here is the patch and the files.
I've integrate too the BeNext Scene Controller.
Thanks you

Original comment by tmartine...@gmail.com on 12 Oct 2014 at 8:03

Attachments:

GoogleCodeExporter commented 9 years ago
thats. Its a start. But I wouldn't tie it into the Scene infrastructure, but 
rather expose ValueID's for each Scene.

Can you explain why you made changes to the Device_Config.xml file? These 
mappings are dictacted by Z-Wave, so they shouldn't need to be altered. (and 
devices that support Optional command classes would still work without having 
to specify additional CC's here). 

Also, I suspect the CentralScene class would support a Capabilities_Get message 
that would at least indicate how many scenes the device supports. I'd like to 
check that out as well. 

Original comment by jus...@dynam.ac on 15 Oct 2014 at 1:05

GoogleCodeExporter commented 9 years ago

Original comment by jus...@dynam.ac on 15 Oct 2014 at 2:54

GoogleCodeExporter commented 9 years ago
Hi,
I've used your patch as a good start to the CentralScene, but made a few 
changes -
1) Scenes are exported as ValueInts.
2) the int represents the time when the Scene should be activated. 
3) I've put in some testing code to try to figure out the Capabilities decode. 
4) till we get Capabilities figured out - You need to specify the number of 
Scenes supported in the device config file via the option scenecount. 

I'd apriciate some testing/feedback -
1) Please remove the SceneController from your network - remove zwcfg_*.xml and 
restart your OZW app.
2) Include the Controller via whatever addnode function.
3) For the BeNext Scene Controller - Perform some testing to make sure the 
ValueID's are exposed and notifications are sent when you click a scene.
4) Send me (or attach to Issue 367) the full log file so I can see if we can 
figure out the Capabilities decode. 

Cheers

Original comment by jus...@dynam.ac on 9 Jan 2015 at 7:18

GoogleCodeExporter commented 9 years ago
Hello,
I've made some test with your version and it's working very well !!
I've removed the zwcfg* file ans restart my OZW app.
All work as expected.
Here is my log file, sorry it's big but i've 35 nodes in my network.
Do you need something else ?
Thanks you very much !!

Cheers

Original comment by tmartine...@gmail.com on 12 Jan 2015 at 9:35

Attachments:

GoogleCodeExporter commented 9 years ago
Unfortunately it was asleep, and we never got to the QueryStage to check the 
capabilities. Can you retry, but after letting OZW query the other nodes, then 
press and hold any button for 18 seconds(!). This will force a wakeup according 
to the manual. 

Original comment by jus...@dynam.ac on 15 Jan 2015 at 12:53

GoogleCodeExporter commented 9 years ago
Any chance to retest?

Original comment by jus...@dynam.ac on 20 Jan 2015 at 6:42

GoogleCodeExporter commented 9 years ago
Hello,
I've just retest. I have exclude and include it again.
Here is the full log, the node id is 65.
Thanks you

Original comment by tmartine...@gmail.com on 21 Jan 2015 at 12:30

Attachments:

GoogleCodeExporter commented 9 years ago
Hello,
My last file was wrong. My patch was already applied.

With your version, that doesn't work as expected, i always have an error when i 
press a button :

Node065, No ValueID created for Scene X (X: Scene Number)

Here is the full log, the node id is 65.

Thanks you

Original comment by tmartine...@gmail.com on 24 Jan 2015 at 11:39

Attachments:

GoogleCodeExporter commented 9 years ago
Could you apply this patch and send me the output.(its on top of Revision 1003 
but should apply to earlier versions as well)

Make sure you remove the zwcfg_*.xml file and do a wakeup after OZW is started 
up (press and hold any button for 18 seconds)

Original comment by jus...@dynam.ac on 1 Feb 2015 at 5:54

Attachments:

GoogleCodeExporter commented 9 years ago
Hello, thanks you.
Here is the new output.(Node id 65)

Original comment by tmartine...@gmail.com on 1 Feb 2015 at 7:08

Attachments:

GoogleCodeExporter commented 9 years ago
Ok. I see whats going on now:
2015-02-01 19:51:22.852 Info, Node065, Optional command classes controlled by 
node 65:
2015-02-01 19:51:22.852 Info, Node065, CentralScene - Created 1
2015-02-01 19:51:22.852 Info, Node065, COMMAND_CLASS_CENTRAL_SCENE

This Device doesn't implement CENTRAL_SCENE, but rather controls it. This is 
only partially supported by OZW. 

Attached patch should get you going. Please apply over a clean copy of revision 
1003

Original comment by jus...@dynam.ac on 2 Feb 2015 at 1:01

Attachments:

GoogleCodeExporter commented 9 years ago
Hello, i've applied the patch to a clean copy.
Here is the logs but i don't see any changes.
Thanks you

Original comment by tmartine...@gmail.com on 2 Feb 2015 at 8:34

Attachments:

GoogleCodeExporter commented 9 years ago
Actually its working now. You should see some new ValueID's exported - "Scene 
Count" and "Scene 1" to "Scene 16"

I'm also seeing that its responding to one of the Capability tests I've 
included:
Received: 0x01, 0x09, 0x00, 0x04, 0x00, 0x41, 0x03, 0x5b, 0x02, 0x08, 0xe1

the 0x5b is the CentalScene CC
the 0x02 I assume is a Capability Report Message
and the 0x08 would be I assume the Number of Scene's it supports. But in this 
case, its half of what the SceneController actually reports, but considering it 
duplicates 8 buttons with a doubleclick, I'm wondering if this is a bug or not. 
Neverless, the Config File works around that issue. 

Please try revision 1006 with the following tests:
1) Remove zwcfg_*.xml and restart
2) Restart with zwcfg_*.xml present
3) apply patch "remove_scene_controller_config.patch", remove zwcfg_*.xml and 
restart.

On tests 1 and 2 you should see a Scene Count ValueID with a value of 16, and 
16 ValueID's named "Scene <x>"
On tests 3 you should see a Scene Count ValueID with a value of 8 and 8 
ValueID's named "Scene <x>"

if all works well, you can revert the patch in 3 by typing "svn revert 
config/manufacturer_specific.xml"

Many Many Thanks for your testing. Its really appreciated.... Hopefully this 
should complete it. 

Original comment by jus...@dynam.ac on 3 Feb 2015 at 6:38

Attachments:

GoogleCodeExporter commented 9 years ago
Hello,
Thanks you it seems to work now !
I'm still having an issue but i don't if it's related to openzwave or 
python-openzwave :
when i push a button, i have this error message :
Exception KeyError: (91,) in 'libopenzwave.notif_callback' ignored

Original comment by tmartine...@gmail.com on 3 Feb 2015 at 8:01

GoogleCodeExporter commented 9 years ago
Hello, I didn't find a way to make it work.
I always have this warning when a push a button : No ValueID created for Scene 
1 (or 2,3...)
Thanks you !

Original comment by tmartine...@gmail.com on 22 Feb 2015 at 11:33

GoogleCodeExporter commented 9 years ago
can you attach a log?

Original comment by jus...@dynam.ac on 22 Feb 2015 at 2:04

GoogleCodeExporter commented 9 years ago
Here are the log and the zwcfg xml file
Thanks you !

Original comment by tmartine...@gmail.com on 22 Feb 2015 at 2:18

Attachments: