roshub / vapor_master

high availability ros master
Apache License 2.0
17 stars 8 forks source link

rosparam not working #22

Closed sevenbitbyte closed 5 years ago

sevenbitbyte commented 5 years ago

Issues

Testing

Manual testing steps to encounter rosparam failure:

rosparam list                           # failing
rosparam get "foo"                  # working
rosparam set "foo" "bar"         # working
rosparam get "foo"                  # failing

Applying fix

we've merged a fix here and have deployed to the snap store.

You can update your installation with:

snap refresh vapor-master

Root Cause

Mistake in refactoring caused an off by one in array construction:

Future Work

Time for unit and integration tests