search

roshub / vapor_master

high availability ros master
Apache License 2.0
17 stars 8 forks source link

Fix test_rosmaster failures, bump version to 0.5 #34

Closed NickZ closed 5 years ago

NickZ commented 5 years ago

Previously, as discussed in #33, vapor_master was failing a number of tests from the official test_rosmaster rostest in the ros_comm package. The bugs that have prevented it from passing these tests have been fixed.

  console.log tests/__tests__/test_rosmaster-rosmaster-test.js:54
    test_rosmaster.rosunit-test_rosmaster_registerPublisher_invalid/testRegisterPublisherInvalid: passed
    test_rosmaster.rosunit-test_rosmaster_registerPublisher_success/testRegisterPublisherSuccess: passed
    test_rosmaster.rosunit-test_rosmaster_registerPublisher_types/testRegisterPublisherTypes: passed
    test_rosmaster.rosunit-test_rosmaster_registerService_invalid/testRegisterServiceInvalid: passed
    test_rosmaster.rosunit-test_rosmaster_registerService_success/testRegisterServiceSuccess: passed
    test_rosmaster.rosunit-test_rosmaster_registerSubscriber_invalid/testRegisterSubscriberInvalid: passed
    test_rosmaster.rosunit-test_rosmaster_registerSubscriber_simple_success/testRegisterSubscriberSimpleSuccess: passed
    test_rosmaster.rosunit-test_rosmaster_simple_API/testGetPid: passed
    test_rosmaster.rosunit-test_rosmaster_simple_API/testGetUri: passed
    test_rosmaster.rosunit-test_rosmaster_unregisterPublisher_invalid/testUnregisterPublisherInvalid: passed
    test_rosmaster.rosunit-test_rosmaster_unregisterPublisher_success/testUnregisterPublisherSuccess: passed
    test_rosmaster.rosunit-test_rosmaster_unregisterService_invalid/testUnregisterServiceInvalid: passed
    test_rosmaster.rosunit-test_rosmaster_unregisterService_success/testUnregisterServiceSuccess: passed
    test_rosmaster.rosunit-test_rosmaster_unregisterSubscriber_invalid/testUnregisterSubscriberInvalid: passed
    test_rosmaster.rosunit-test_rosmaster_unregisterSubscriber_success/testUnregisterSubscriberSuccess: passed

    SUMMARY
    result: SUCCESS
    tests: 15
    errors: 0
    failures: 0

To run these tests: Run catkin_make in the tests/native_client folder, and then source the file tests/native_client/devel/setup.bash.

Then run:

yarn test

sevenbitbyte commented 5 years ago

This PR looks rushed, no time for comment, no linked issues, no repro steps, and does not explain the issue in a way a layperson can follow. BUT code quality looks good. I have filed #35 @NickZ Please update your PR message to include the fields listed in issue #35