search

rosin-project / metacontrol_sim

2 stars 4 forks source link

Move rosgraph_manipulator to a separate repo #42

Open chcorbato opened 4 years ago

chcorbato commented 4 years ago

Move rosgraph_manipulator to a separate repo, because it is a metacontrol asset that should be "experiment/system" agnostic, but platform specific for ROS1

ipa-nhg commented 4 years ago

We, at IPA, have a potential new use for the rosgraph_manipulator, is it possible to make it generic? For example take the list of nodes to be killed from a yaml file.

make it sense for you @marioney ? We can also support/send a suggestion as PR

marioney commented 4 years ago

is it possible to make it generic? For example take the list of nodes to be killed from a yaml file.

I think that's a good idea. And of course we would really appreciate your support on this.

We can also support/send a suggestion as PR

I think a PR will be good, so we can discuss on the details for the change there

As of now, we're only killing the move_base node, but actually, the kill_node function accepts the node name and namespace, so it's just a matter of changing the way it's used.

ipa-nhg commented 4 years ago

Move rosgraph_manipulator to a separate repo: :heavy_check_mark: done -> https://github.com/tud-cor/mc_rosgraph_manipulator/pull/2

About how to make it generic I will open a new issue for mc_rosgraph_manipulator to discuss potential solutions