search

rosin-project / rosgraph_monitor

Monitors the status of nodes and topics currently running
Apache License 2.0
1 stars 2 forks source link

Unify observer branches #11

Open marioney opened 3 years ago

marioney commented 3 years ago

We have two branches now safety_observer and observers

I'm not sure what are the differences, but I guess we should merge them.

@ipa-hsd any comments?

hsd-dev commented 3 years ago

Can you check this commit? Seems like you added the script, not sure if it is still needed.

marioney commented 3 years ago

No, I don't think we need that script anymore.

I'm not even sure why I created that script. In any case the reasoner should decide when an objective is in error.

hsd-dev commented 3 years ago

Apart from that script, the calculation of safety QA is different. In observers branch it is: https://github.com/rosin-project/rosgraph_monitor/blob/674fc297aa8b28a0a7af40c79871a8af27ea026a/src/rosgraph_monitor/observers/safety_quality_observer.py#L18-L44

marioney commented 3 years ago

Apart from that script, the calculation of safety QA is different. In observers branch it is:

I guess those changes need to stay, I'm not sure why I made those, but that's the version we used for the experiments

hsd-dev commented 3 years ago

I guess those changes need to stay

OK in that case, we can cherry-pick that commit into safety_observer branch and delete observers branch.