search

rosin-project / rxros

Reactive programming for ROS
BSD 3-Clause "New" or "Revised" License
48 stars 6 forks source link

Move CTPL and Scheduler headers out of rxros #11

Closed gavanderhoorn closed 5 years ago

gavanderhoorn commented 5 years ago

greping for Scheduler.h (and InterruptableSleep.h, ctpl.h and Cron.h) it would appear they are not used by rxros itself, but only by the BrickPi classes.

If that is correct, then those headers should not be part of the rxros package, but should be hosted by either the BrickPi package(s) or in some other location.

As-is, any package dependent on rxros will find ctpl.h, Scheduler.h and Cron.h on their include path, which may break include order or clash with existing files.

gavanderhoorn commented 5 years ago

Implemented in #14.

gavanderhoorn commented 5 years ago

Fixed in #14 and rosin-project/rxros_examples#1.