search

rosin-project / rxros

Reactive programming for ROS
BSD 3-Clause "New" or "Revised" License
48 stars 6 forks source link

Suggestion: use gavanderhoorn/rxcpp_vendor #12

Closed gavanderhoorn closed 5 years ago

gavanderhoorn commented 5 years ago

I've just created a Catkin package out of RxCpp: gavanderhoorn/rxcpp_vendor.

This allows us to package RxCpp irrespective of what upstream is doing (they don't provide Debian packages) and we don't need to ship copies of the headers ourselves (currently in rxros/include/rxcpp), which increases maintenance effort and has other disadvantages.

To use it, add the following to the package manifest of rxros:

  <build_depend>rxcpp_vendor</build_depend>
  <build_export_depend>rxcpp_vendor</build_export_depend>

And in the CMakeLists.txt add rxcpp_vendor both to the find_package(catkin REQUIRED COMPONENTS ..) and the catkin_package(CATKIN_DEPENDS .. ) lists.

And of course make sure to have a clone of gavanderhoorn/rxcpp_vendor in the workspace.

gavanderhoorn commented 5 years ago

Implemented in #14.

gavanderhoorn commented 5 years ago

Fixed in #14 and rosin-project/rxros_examples#1.