search

rosin-project / rxros

Reactive programming for ROS
BSD 3-Clause "New" or "Revised" License
48 stars 6 forks source link

Refactor tf support: introduce rxros_tf #24

Closed gavanderhoorn closed 4 years ago

gavanderhoorn commented 4 years ago

As per subject.

This refactors rxros to no longer contain any dependencies on tf. All TF related functionality is migrated to rxros_tf. build and exec dependencies have been updated accordingly.

Compile-tested by building the rxros_examples packages (but those don't appear to use TF, so it's not a very useful test).

Fixes #3 and fixes #8.

gavanderhoorn commented 4 years ago

I'd like to get this in before doing the initial release.

gavanderhoorn commented 4 years ago

Thanks @henrik7264.

Was this what you had in mind as well?

henrik7264 commented 4 years ago

@gavanderhoorn yes it is very nice work. I have though proposed a small enhancement in #27

gavanderhoorn commented 4 years ago

See #28, which resolves #27.

wasowski commented 4 years ago

Thank you guys, and apologies for checking out :) Reality has caught up with me ...