search

rosin-project / rxros

Reactive programming for ROS
BSD 3-Clause "New" or "Revised" License
48 stars 6 forks source link

Issue #15: rxros::spin() function uses unnecessary many threads #30

Closed henrik7264 closed 4 years ago

henrik7264 commented 4 years ago

Fix of Issue #15: rxros::spin() function uses unnecessary many threads. Default is now set to one thread and the programmer can if needed specify more threads by giving an argument to the spin function.

gavanderhoorn commented 4 years ago

@henrik7264: you should rebase your PR once #33 gets merged.

gavanderhoorn commented 4 years ago

Guys: with ROSCon next week it would be good to come to a conclusion here (so @wasowski would have time to update his slides as well).

Either we merge this as-is and decide about dropping rxros:: wrappers for things like spin(), or we remove the wrappers in this PR as well.

@henrik7264: what would have your preference?

henrik7264 commented 4 years ago

I have commited an update where the rxros::init, rxros::ok and rxros::spin have been removed. I would actually have like also to remove the logging and parameter class as proposed above, but we can talk about this after the conference. If we merge this commit to master and release it, @wasowski must update his notes. I think it is relative safe to release it. I shall make some tests tomorrow. Please, @gavanderhoorn and @wasowski take a look at the Readme. It was put together a bit fast.

henrik7264 commented 4 years ago

Please also remember that this commit has impact on the RxROS examples.

https://github.com/rosin-project/rxros_examples/pull/11

wasowski commented 4 years ago

I merged since, it did not seem to require a rebase.