Don't load list by default and other fixes

rosjava / android_apps

Applications built on top of the rosjava android libraries.

132 stars 112 forks source link

Don't load list by default and other fixes #60

Closed adamantivm closed 7 years ago

adamantivm commented 7 years ago

This change allows using map_nav also with empty or pre-loaded maps. If the map manager needs to be used, there is still the "choose map" button for this purpose. This also fixes a couple of nits: re-enables NTP and fixes a wrong type in the /initialpose publisher.

@jubeira @ernestmc can one of you let me know what you think?

@tulku FYI

jubeira commented 7 years ago

LGTM; I have some questions about this:

Why was the message changed from pose to pose with covariance?
I think it's good to disable the map chooser by default; the package that provides that service doesn't work well in ROS Kinetic. How is the pre-loaded / empty map used in that case?

adamantivm commented 7 years ago

I don't know why the /initialpose was using the message type PoseStamped. The rest of the system, including rviz, move_base and even the initial pose publisher in this repo were using PoseWithCovarianceStamped, so this was causing a failure and disconnection, it wasn't working before.

The pre-loaded empty map is simply displayed in the map layer, was you would expect.