Update gradle wrapper. - Githubissues

rosjava / android_core

Android libraries for rosjava

146 stars 166 forks source link

Update gradle wrapper. #225

Closed r2DoesInc closed 9 years ago

r2DoesInc commented 9 years ago

Update to use local maven repository. Remove library application ids Dont crash on lint errors

stonier commented 9 years ago

Just applied many of the changes from @talregev in #226. This updated the gradle wrapper and removed the library application ids already.

Questions:

Is there a reason mavenLocal() is needed in the buildscript?
Is the lint update actually necessary?

I'm not actually crashing/failing to build without either of these changes. Is there something in your use case that requires these?

r2DoesInc commented 9 years ago

mavenLocal() was needed to use the locally built rosjava dependencies. I believe there was a small lint error - a missing translation perhaps - that was causing the build to stop.

stonier commented 9 years ago

Ok.

Closing this for now - if you hit the lint error again, make a new issue with some pastes of the output and let's tackle it directly.