search

rosjava / android_core

Android libraries for rosjava
144 stars 166 forks source link

Make toast() function protected at MasterChooser.jar (on android_10) #227

Closed talregev closed 9 years ago

talregev commented 9 years ago

If some drive this class (like i do to extend master-chooser with some ability) , he need to copy toast class, or worst, make Toast for himself.

please fix.

Tal.

stonier commented 9 years ago

I imagine this got done in your pull request changes to make it protected. Anything else needed?

talregev commented 9 years ago

I think it needed by default. It open source and people will reuse the code. So why not?

stonier commented 9 years ago

@talregev the protected change is already in here.

My question - do you need anything else? Can we close this?

talregev commented 9 years ago

not as i remember. i will open another if i needed.

stonier commented 9 years ago

Aight...thanks! :neckbeard: