search

rosjava / android_core

Android libraries for rosjava
145 stars 166 forks source link

Fixed NodeMainExecutorService and added dependency of fixed rosjava_c… #255

Closed stratomda closed 7 years ago

stratomda commented 7 years ago

This fixes #254. This however has a dependency on rosjava/rosjava_core#233 and requires package a bumped package for rosjava_core. I assumed package rosjava_core:0.2.2.

adamantivm commented 7 years ago

@stratomda any chance we can get this targeted for kinetc?

stratomda commented 7 years ago

@adamantivm I can merge this into kinetic branch. You'll have to give me a few days to get my workspace spun up. I needed this for a specific project using indigo, but I am using my own maven repo, so no need to target indigo.

adamantivm commented 7 years ago

@stratomda I released the rosjava_core fix for indigo and cherry picked for kinetic. We could do the same for this fix as well. Could you address that tiny nit and then I can take care of the rest?

stratomda commented 7 years ago

Will do. Thanks for all the work you do.

stratomda commented 7 years ago

@adamantivm removed extra line.

adamantivm commented 7 years ago

JFYI, this and rosjava/rosjava_core#233 are merged, tagged and released to the rosjava maven repo.