search

rosjava / android_core

Android libraries for rosjava
145 stars 166 forks source link

Notification crashes yet. #293

Open blmhemu opened 5 years ago

blmhemu commented 5 years ago

Hey, although the android_core (notifications) has been updated to work with targetsdk 28, when I make an app, it still crashes. (My guess, it has not been updated in maven repo !!). The error is same as #283 . I am running Android oreo 8.1. The app (notification) responds fine when targetsdk is set to 25.

jubeira commented 5 years ago

Thanks for the report @blmhemu. Note that if you are building an app and you want that fix you need to depend on android_core_components:[0.4, 0.5) instead of android_10:[0.3, 0.4) and android_15:[0.3, 0.4). If I'm not mistaken those changes are already in maven (see https://github.com/rosjava/rosjava_mvn_repo/pull/62).

What artifacts are you using in your Gradle buildscript?

blmhemu commented 5 years ago

implementation 'org.ros.android_core:android_core_components:0.4.0' is the one i am using. Here is the build.gradle file : https://drive.google.com/drive/folders/1dZ33Vh29nI4SeLRB7IjNaCB5Krf5bD12?usp=sharing

jubeira commented 5 years ago

Hmm then that's weird; I don't recall seeing that. I'll take a look when I have some time. Perhaps we can incorporate your fix otherwise.

yadajin commented 4 years ago

Could not get resource 'https://github.com/rosjava/android_core/raw/kinetic/buildscript.gradle'. Why does the compiler always report this error? Can you help me?

alcabo commented 4 years ago

any update over this issue?

I am also experiencing the notification issue with targetsdk 29 and implementation 'org.ros.android_core:android_core_components:0.4.0'

The notification dialog asking for shutting down crashes, leaving all ros nodes registered in the master. After a long time without working with my rosjava apps, I started updating all libraries (including android-studio, SDK, android UIs, rosjava dependencies, etc.) and eventually I noticed this problem with the shutdown.

alcabo commented 4 years ago

confirmed. The maven dependency is not updated.

One could download the code for android_core lib, update the NodeMainExecutorService.java with the fix by @blmhemu (https://github.com/blmhemu-rosjava/android_core/blob/kinetic/android_10/src/org/ros/android/NodeMainExecutorService.java), modify if some resource is missing (e.g., R.drawable.shutdown), compile and finally use the generated .aar in the own android ROS project.