roskart / dropwizard-jaxws

Dropwizard bundle that enables building SOAP web services and clients using JAX-WS API
Apache License 2.0
43 stars 36 forks source link

Null pointer on missing credentials #19

Closed ghost closed 5 years ago

ghost commented 5 years ago

If the supplied username or password in a request are null there is a nasty NullPointerException in the logs and the caller service receives an "Internal server error" message. Add a null check for username and password, if either is null the authorization process should check the security token instead.

roskart commented 5 years ago

Thanks for contributing. The fix makes sense, but I wonder what is the point of new dependencies in commits 152e1f8 and 8601225?

ghost commented 5 years ago

Thanks for contributing. The fix makes sense, but I wonder what is the point of new dependencies in commits 152e1f8 and 8601225?

I had a problem with IntelliJ not finding classes from jaxws. Now it works, I removed those dependencies

roskart commented 5 years ago

Dependency in example project remains. I'll merge this and remove it later.