search

roskenet / spring-javafx-examples

Example apps for springboot-javafx-support. See
https://www.felixroske.de/page/programmierung/index.html
159 stars 66 forks source link

make `launchApp` public on AbstractJavaFxApplicationSupport #1

Closed jangalinski closed 7 years ago

jangalinski commented 7 years ago

I am trying to get a springboot/JavaFx application to run with kotlin.

but when I do

@SpringBootApplication
class MyApplication : AbstractJavaFxApplicationSupport()

fun main(args: Array<String>)  {
  AbstractJavaFxApplicationSupport.launchApp(MyApp::class.java, MyView::class.java, args)
}

I cannot access the launchAppmethod since it is of protected scope.

Could you change visibility to support this usecase? It's not very useful to have this one protected imho, since the original launch is public, so you are not really hiding implementation details ...

roskenet commented 7 years ago

Yes, you are absolutely right! Makes no real sense to narrow the scope. Will do this. https://github.com/roskenet/springboot-javafx-support/issues/13

roskenet commented 7 years ago

Closed here in favour of https://github.com/roskenet/springboot-javafx-support/issues/13